Allow to add organization members as collaborators on organization owned repositories

[adelowo]

Fixes #4507

Deleted the translation text since I couldn't find it being used elsewhere with ag "settings.user_is_org_member"

[lafriks]

Won't there be side effects when checking rights?

[adelowo]

I just tried regular pushing via the cli and viewing the repo via the UI..
I could run more checks but if you do know of a potential side effect kindly inform me so I can verify

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@a7ee4a6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4748   +/-   ##
=========================================
  Coverage          ?   37.56%           
=========================================
  Files             ?      317           
  Lines             ?    46822           
  Branches          ?        0           
=========================================
  Hits              ?    17588           
  Misses            ?    26735           
  Partials          ?     2499

Impacted Files	Coverage Δ
routers/repo/setting.go	11.2% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ee4a6...33ff015. Read the comment docs.

[lafriks]

What if someone is added to the team with less settings for same repo, will there won't be mismatch when accessing ui

[adelowo]

Would update this comment as @lafriks after extensive testing

[adelowo]

I am yet to find any unexpected side effects

[lunny]

@lafriks Since #5314 has supported permission check for organization member as a collaborator, I think this is meaningful. See https://github.com/go-gitea/gitea/blob/master/models/repo_permission.go#L142 .

[adelowo]

Heads up to anyone merging this. Can you kindly verify the deleted translation text is still not being used ?

[lafriks]

@adelowo does not seems to