Skip to content

Change Collaborators List to include permissions #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zeripath
Copy link
Contributor

This pull request adjusts the api for /api/v1/repos/:owner/:reponame/collaborators to return the permissions for each collaborator, making this api a bit more useful.

@zeripath
Copy link
Contributor Author

The CI build is failing due to the SDK being slightly out-of-date. There is a pull request for this at go-gitea/go-sdk#116

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2018
@zeripath
Copy link
Contributor Author

zeripath commented Sep 4, 2018

Hmm... Thinking on there is a way of adding this without making a breaking change to the api.

Would it be more preferable to change the api to:

/api/v1/repos/{owner}/{repo}/collaborators/{collaborator}/permissions

and:

/api/v1/repos/{owner}/{repo}/permissions

?

@lafriks lafriks added type/bug modifies/api This PR adds API routes or modifies them and removed type/bug labels Sep 12, 2018
@zeripath zeripath force-pushed the change-collab-api branch 4 times, most recently from 654caa9 to f34e46e Compare September 21, 2018 18:17
@zeripath zeripath force-pushed the change-collab-api branch 2 times, most recently from 84faf46 to 7e0bc54 Compare September 29, 2018 13:55
@zeripath zeripath force-pushed the change-collab-api branch 5 times, most recently from 630b7c4 to ec5756b Compare October 25, 2018 19:12
@zeripath zeripath force-pushed the change-collab-api branch 4 times, most recently from c56810a to 33dade7 Compare October 31, 2018 21:23
@stale
Copy link

stale bot commented Jan 8, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 8, 2019
@techknowlogick techknowlogick added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 13, 2019
@stale stale bot removed the issue/stale label Jan 13, 2019
@zeripath zeripath closed this Feb 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@zeripath zeripath deleted the change-collab-api branch December 29, 2022 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants