Explicitly decide whether to use TLS in mailer's configuration#5024
Merged
techknowlogick merged 8 commits intoNov 26, 2018
Conversation
adelowo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5024 +/- ##
==========================================
+ Coverage 37.45% 37.45% +<.01%
==========================================
Files 312 312
Lines 46510 46510
==========================================
+ Hits 17419 17422 +3
+ Misses 26599 26597 -2
+ Partials 2492 2491 -1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
adelowo
changed the title
lunny
approved these changes
Oct 6, 2018
bkcsoft
added
lgtm/need 1
Member
|
It should probably use default depending on port set to not break compatibility |
techknowlogick
approved these changes
Nov 1, 2018
bkcsoft
added
lgtm/done
techknowlogick
requested changes
Nov 1, 2018
…citly_use_tls_for_mailer
adelowo
force-pushed
the
explicitly_use_tls_for_mailer
branch
from
4fd1d20 to
94a93ab
Compare
Member
Author
|
Sorry for not updating this on time. I have been a little busy this past 2 weeks. I would be updating my other PRs before the start of next week |
Member
|
@adelowo no worries. We appreciate the time you are able to give. |
techknowlogick
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4820