Skip to content

refactor: err != nil check, just return error instead#5093

Merged
techknowlogick merged 4 commits into
go-gitea:masterfrom
appleboy:refactor1000
Oct 18, 2018
Merged

refactor: err != nil check, just return error instead#5093
techknowlogick merged 4 commits into
go-gitea:masterfrom
appleboy:refactor1000

Conversation

@appleboy
Copy link
Copy Markdown
Member

@appleboy appleboy commented Oct 17, 2018

as title.

@appleboy appleboy added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 17, 2018
@appleboy appleboy added this to the 1.7.0 milestone Oct 17, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 17, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 17, 2018 •
edited
Loading

Codecov Report

Merging #5093 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5093      +/-   ##
==========================================
+ Coverage   37.41%   37.42%   +<.01%     
==========================================
  Files         306      306              
  Lines       45381    45378       -3     
==========================================
+ Hits        16980    16982       +2     
+ Misses      25947    25943       -4     
+ Partials     2454     2453       -1
Impacted Files Coverage Δ
models/migrations/v68.go 0% <0%> (ø) ⬆️
models/repo_indexer.go 50.84% <0%> (ø) ⬆️
models/repo_list.go 63.37% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b8103...9499298. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2018
@lafriks lafriks added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 17, 2018
@lafriks
Copy link
Copy Markdown
Member

lafriks commented Oct 17, 2018

blocked until 1.6.0-rc1 is released

@lunny lunny removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 18, 2018
@techknowlogick techknowlogick merged commit 1e34413 into go-gitea:master Oct 18, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+2 more reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

@tonivj5 tonivj5 tonivj5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

8 participants

@appleboy @codecov-io @lafriks @lunny @jonasfranz @tonivj5 @techknowlogick @bkcsoft