Add comment replies#5104
Merged
techknowlogick merged 5 commits intoOct 22, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5104 +/- ##
==========================================
+ Coverage 37.43% 37.44% +<.01%
==========================================
Files 308 308
Lines 45715 45718 +3
==========================================
+ Hits 17114 17119 +5
Misses 26141 26141
+ Partials 2460 2458 -2
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
jonasfranz
added
type/enhancement
7 tasks
kolaente
reviewed
Oct 20, 2018
| } | ||
| } | ||
| } | ||
| reviewID := review.ID |
Member
There was a problem hiding this comment.
Why are you putting this in an extra variable instead of directly modifiying review.ID?
techknowlogick
approved these changes
Oct 20, 2018
Member
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
Same nit as @kolaente, but otherwise LGTM.
bkcsoft
added
lgtm/need 1
…enhancement/review-replies
Member
Author
|
@kolaente @techknowlogick done |
appleboy
approved these changes
Oct 22, 2018
bkcsoft
added
lgtm/done
kolaente
approved these changes
Oct 22, 2018
Member
Author
|
@go-gitea/owners Drone isn't reporting a status |
Contributor
|
GitHub is still working through the backlogs (https://status.github.com/), but it should mostly work now. |
Member
|
@JonasFranzDEV please send backport. |
Merged
techknowlogick
added
backport/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #4389 and #5100.
This PR makes it possible to reply to review comments. These replies will be also shown at the "Conversation" tab.
At the moment it is only possible to reply to comments if there is already a review at the specific line. That can be fixed, but requires translations. We should discuss about including this in 1.6.
Without this enhancement the review comment feature seems buggy to the end user.