Skip to content

Use named const instead of a raw string #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 2 commits into from
Oct 20, 2018
Merged

Use named const instead of a raw string #5115

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8f325
Use named const instead of a raw string
Oct 19, 2018
927cf48
Merge branch 'master' into gocritic-namedConst
lunny Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"errors"
"fmt"
"image"

// Needed for jpeg support
_ "image/jpeg"
"image/png"
Expand Down Expand Up @@ -1387,7 +1388,7 @@ func SearchUsers(opts *SearchUserOptions) (users []*User, _ int64, _ error) {
opts.Page = 1
}
if len(opts.OrderBy) == 0 {
opts.OrderBy = "name ASC"
opts.OrderBy = SearchOrderByAlphabetically
}

users = make([]*User, 0, opts.PageSize)
Expand Down