Retry test-fixtures loading in case of transaction rollback#5125
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5125 +/- ##
=========================================
- Coverage 37.4% 37.4% -0.01%
=========================================
Files 308 308
Lines 45605 45612 +7
=========================================
+ Hits 17057 17059 +2
- Misses 26091 26094 +3
- Partials 2457 2459 +2
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lunny
approved these changes
Oct 20, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Oct 20, 2018
bkcsoft
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some circumstances, the transaction in the test fixture loading function would rollback when a transaction conflict occurs.
Retry it five times to at least reduce the chance of failures.