Skip to content

Update build tags for sqlite_unlock notify#5144

Merged
lunny merged 1 commit into
go-gitea:masterfrom
typeless:update-build-tags-for-unlock-notify
Oct 23, 2018
Merged

Update build tags for sqlite_unlock notify#5144
lunny merged 1 commit into
go-gitea:masterfrom
typeless:update-build-tags-for-unlock-notify

Conversation

@typeless
Copy link
Copy Markdown
Contributor

@typeless typeless commented Oct 23, 2018 •
edited
Loading

Fixes #2040

@lunny lunny added this to the 1.7.0 milestone Oct 23, 2018
@typeless typeless force-pushed the update-build-tags-for-unlock-notify branch from b896e2c to 74ac735 Compare October 23, 2018 05:33
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #5144 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5144      +/-   ##
==========================================
- Coverage   37.49%   37.48%   -0.01%     
==========================================
  Files         309      309              
  Lines       45782    45782              
==========================================
- Hits        17164    17161       -3     
- Misses      26157    26159       +2     
- Partials     2461     2462       +1
Impacted Files Coverage Δ
models/repo_indexer.go 50.84% <0%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce72d4...b56c872. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2018
@typeless typeless force-pushed the update-build-tags-for-unlock-notify branch from 74ac735 to b56c872 Compare October 23, 2018 05:40
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2018
@lunny lunny merged commit 25c49cf into go-gitea:master Oct 23, 2018
This was referenced Oct 23, 2018
Closed
Closed
@typeless typeless deleted the update-build-tags-for-unlock-notify branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/testing

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

random database lock when sqlite database

5 participants

@typeless @codecov-io @lunny @sapk @bkcsoft