Skip to content

Fix dependent issue searching when gitea is run in subpath#5392

Merged
techknowlogick merged 4 commits into
go-gitea:masterfrom
lafriks-fork:fix/dep_suburl_repolink
Nov 25, 2018
Merged

Fix dependent issue searching when gitea is run in subpath#5392
techknowlogick merged 4 commits into
go-gitea:masterfrom
lafriks-fork:fix/dep_suburl_repolink

Conversation

@lafriks
Copy link
Copy Markdown
Member

@lafriks lafriks commented Nov 23, 2018

Fixes #5389

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 23, 2018

Codecov Report

Merging #5392 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
- Coverage   37.45%   37.45%   -0.01%     
==========================================
  Files         312      312              
  Lines       46509    46509              
==========================================
- Hits        17419    17418       -1     
  Misses      26599    26599              
- Partials     2491     2492       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e587e0...0cf404a. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2018
@markusamshove
Copy link
Copy Markdown
Contributor

I can confirm that this works :)

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2018
@techknowlogick techknowlogick merged commit 499d132 into go-gitea:master Nov 25, 2018
@techknowlogick
Copy link
Copy Markdown
Member

@lafriks please send backport 😄

@lafriks lafriks deleted the fix/dep_suburl_repolink branch November 25, 2018 19:23
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Nov 25, 2018
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 25, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API call to fetch issues when adding dependent issue doesn't take ROOT_URL into account

7 participants