Refactor heatmap to vue component#5401
Conversation
|
Are we favouring Vue over react for future? |
|
@pjebs yes |
Codecov Report
@@ Coverage Diff @@
## master #5401 +/- ##
=========================================
Coverage ? 37.44%
=========================================
Files ? 312
Lines ? 46507
Branches ? 0
=========================================
Hits ? 17416
Misses ? 26599
Partials ? 2492
Continue to review full report at Codecov.
|
|
@lafriks I don't know why this happened.
Chrome 70.0.3538.110 |
|
@lafriks I can confirm @yasuokav 's report. |
|
@lunny @yasuokav Can you send the result of http://jsfiddle.net/3wz4xdgq/13/ in your browser ? I suspect getComputedStyle to not work the same depending of browser. |
|
For me on Firefox : |
|
On chrome : That why it doesn't work ... Please use a browser that support standard 😆 |
|
Found the bug on chrome and it is still open : https://bugs.chromium.org/p/chromium/issues/detail?id=558165 |
|
@sapk The results are the same as yours |
|
Maybe could we use a polyfill for getComputedStyle? |
|
ah shity browser standard support :D |
|
@xxxtonixxx I don't think we can have a polyfill since the func is already defined. The workaround that I see is creating a hidden el with the class un order for webkit to compute the style. An other would be to define the variable in the theme or keep like before a config that define the JS var. |

Looks about the same but fixes problems reported in #5191. Also removed setting for range color and instead moved it to less/css so that colors can be specified in theme css