refactor: replace lint to revive#5422
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5422 +/- ##
=======================================
Coverage 37.57% 37.57%
=======================================
Files 317 317
Lines 46824 46824
=======================================
Hits 17593 17593
Misses 26732 26732
Partials 2499 2499Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lunny
approved these changes
Nov 28, 2018
bkcsoft
added
lgtm/need 1
Aragur
added a commit
to Aragur/revive
that referenced
this pull request
Dec 3, 2018
When merged: go-gitea/gitea#5422 gitea will use revive.
sapk
reviewed
Dec 3, 2018
Member
There was a problem hiding this comment.
Why not keep lint command name as it is the action (linting) not the name tool?
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
techknowlogick
approved these changes
Dec 3, 2018
bkcsoft
added
lgtm/done
sapk
approved these changes
Dec 3, 2018
mgechev
pushed a commit
to mgechev/revive
that referenced
this pull request
Dec 4, 2018
When merged: go-gitea/gitea#5422 gitea will use revive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint time
revive time