Fix bug on modifying sshd username#5624
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5624 +/- ##
=======================================
Coverage 37.81% 37.81%
=======================================
Files 322 322
Lines 47474 47474
=======================================
Hits 17954 17954
Misses 26933 26933
Partials 2587 2587Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
techknowlogick
approved these changes
Jan 2, 2019
bkcsoft
added
lgtm/need 1
zeripath
approved these changes
Jan 2, 2019
bkcsoft
added
lgtm/done
Member
|
Should this be back port to v1.6 |
Member
|
Please backport to release/1.6 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #5623
Since the regex isn't matching the end-of-line, when using a user whose username starts with "git" it will perform an invalid replace (gitea -> giteaea, git-suffix -> git-suffix-suffix).
Matching against EOL should resolve this issue.