Fix sqlite deadlock when assigning to a PR#5640
Merged
Merged
Conversation
Fix 5639 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5640 +/- ##
==========================================
+ Coverage 37.81% 37.81% +<.01%
==========================================
Files 322 322
Lines 47485 47489 +4
==========================================
+ Hits 17957 17959 +2
- Misses 26939 26941 +2
Partials 2589 2589
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
techknowlogick
approved these changes
Jan 4, 2019
bkcsoft
added
lgtm/need 1
Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Jan 4, 2019
bkcsoft
added
lgtm/done
Member
|
Please backport to release/v1.7 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 5, 2019
* Fix sqlite deadlock when assigning to a PR Fix 5639 Signed-off-by: Andrew Thornton <art27@cantab.net> * More possible deadlocks found and fixed Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
pushed a commit
that referenced
this pull request
Jan 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assigning a user to a PR there was a call to
issue.PullRequest.APIFormat()which causes an deadlock in sqlite due to the internal use of the xorm engine. This PR changes this toissue.PullRequest.apiFormat(sess)passing in the current session and thus avoiding the deadlock.A few other possible deadlocks were also identified.
Fix #5639