Skip to content

handle milestone events for issues and PR#5947

Merged
techknowlogick merged 2 commits into
go-gitea:masterfrom
adelowo:fix_5865
Feb 3, 2019
Merged

handle milestone events for issues and PR#5947
techknowlogick merged 2 commits into
go-gitea:masterfrom
adelowo:fix_5865

Conversation

@adelowo
Copy link
Copy Markdown
Member

@adelowo adelowo commented Feb 3, 2019

Fixes #5865

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 3, 2019
@techknowlogick
Copy link
Copy Markdown
Member

Looks good. Can you add them to the other hook types too?

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 3, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 3, 2019

Codecov Report

Merging #5947 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5947      +/-   ##
==========================================
- Coverage   38.54%   38.54%   -0.01%     
==========================================
  Files         330      330              
  Lines       48518    48526       +8     
==========================================
+ Hits        18700    18703       +3     
- Misses      27111    27117       +6     
+ Partials     2707     2706       -1
Impacted Files Coverage Δ
models/webhook_slack.go 0% <0%> (ø) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c0f7d...7268fcd. Read the comment docs.

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Feb 3, 2019
@adelowo
Copy link
Copy Markdown
Member Author

adelowo commented Feb 3, 2019

@techknowlogick All other webhooks already support this

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2019
@techknowlogick
Copy link
Copy Markdown
Member

@adelowo thanks :)

@techknowlogick techknowlogick merged commit 746cf22 into go-gitea:master Feb 3, 2019
@adelowo adelowo deleted the fix_5865 branch February 3, 2019 18:32
@lunny
Copy link
Copy Markdown
Member

lunny commented Feb 4, 2019

@adelowo I think this should be back port to release/v1.7

adelowo added a commit to adelowo/gitea that referenced this pull request Feb 4, 2019
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 4, 2019
zeripath pushed a commit that referenced this pull request Feb 4, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook empty text

7 participants