Skip to content

API: make sure labels are actually returned#6053

Merged
techknowlogick merged 3 commits into
go-gitea:masterfrom
adelowo:fix_label_api
Feb 13, 2019
Merged

API: make sure labels are actually returned#6053
techknowlogick merged 3 commits into
go-gitea:masterfrom
adelowo:fix_label_api

Conversation

@adelowo
Copy link
Copy Markdown
Member

@adelowo adelowo commented Feb 13, 2019

This fixes an item in #6047 .

I couldn't replicate the other 401 the poster talked about

@adelowo adelowo mentioned this pull request Feb 13, 2019
6 tasks
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 13, 2019

Codecov Report

Merging #6053 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6053      +/-   ##
==========================================
- Coverage   38.87%   38.86%   -0.01%     
==========================================
  Files         345      345              
  Lines       49503    49507       +4     
==========================================
- Hits        19243    19241       -2     
- Misses      27477    27483       +6     
  Partials     2783     2783
Impacted Files Coverage Δ
routers/api/v1/repo/issue_label.go 29.52% <0%> (-0.45%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23414ac...9f543b8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 13, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 13, 2019
@lafriks lafriks added this to the 1.8.0 milestone Feb 13, 2019
@zeripath
Copy link
Copy Markdown
Contributor

I don't think there's a test covering this API, although I understand you can't quite reproduce the issue - it would be good if there was at least a test.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 13, 2019
@techknowlogick techknowlogick merged commit f2256d9 into go-gitea:master Feb 13, 2019
@adelowo adelowo deleted the fix_label_api branch February 13, 2019 15:55
adelowo added a commit to adelowo/gitea that referenced this pull request Feb 13, 2019
@techknowlogick techknowlogick added backport/done All backports for this PR have been created kind/api labels Feb 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants