Skip to content

Delete releases attachments if release is deleted #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 22, 2019
Merged

Delete releases attachments if release is deleted #6068

merged 16 commits into from
Sep 22, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Feb 14, 2019 •
edited
Loading

Fixes #2618.

Figured out #677 is a meta issue for #2618. This PR fixes the last 2 items on the list in #677 .

@codecov-io
Copy link

codecov-io commented Feb 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6322d25). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6068   +/-   ##
=========================================
  Coverage          ?   41.57%           
=========================================
  Files             ?      489           
  Lines             ?    65246           
  Branches          ?        0           
=========================================
  Hits              ?    27128           
  Misses            ?    34631           
  Partials          ?     3487
Impacted Files Coverage Δ
models/migrations/migrations.go 1.3% <ø> (ø)
models/migrations/v80.go 0% <ø> (ø)
models/migrations/v96.go 0% <0%> (ø)
models/release.go 42.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6322d25...889dff6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2019
lafriks
lafriks requested changes Feb 14, 2019
View reviewed changes
@jonasfranz jonasfranz added the type/enhancement An improvement of existing functionality label Feb 15, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Feb 19, 2019
@Smithx10
Copy link

Smithx10 commented Mar 6, 2019

Also, I've noticed that while deleting through the API / SDK it also leaves the TAG. And I don't see Deleting a tag through the API /SDK.

@adelowo adelowo mentioned this pull request Apr 10, 2019
Closed
4 tasks
@lunny
Copy link
Member

lunny commented Apr 11, 2019

conflicted

@kolaente
Copy link
Member

@adelowo please resolve conflicts

@adelowo adelowo force-pushed the delete_releases_attachments_if_release_is_deleted branch from e757621 to c632e48 Compare May 14, 2019 12:29
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 14, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 4, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 4, 2019
@stale stale bot removed the issue/stale label Aug 4, 2019
@zeripath
Copy link
Contributor

zeripath commented Aug 4, 2019

@adelowo I think we could do with this. Any chance you could fix the conflicts?

@lafriks would you be able to re-review?

@lafriks
Copy link
Member

lafriks commented Aug 4, 2019

Yes but that select condition imho still needs to be fixed in migration

@adelowo
Copy link
Member Author

adelowo commented Aug 7, 2019

Will update :)

lunny
lunny requested changes Sep 15, 2019
View reviewed changes
@adelowo adelowo force-pushed the delete_releases_attachments_if_release_is_deleted branch from ca5222b to 797f275 Compare September 17, 2019 23:21
lunny
lunny requested changes Sep 18, 2019
View reviewed changes
lunny
lunny reviewed Sep 18, 2019
View reviewed changes
lunny
lunny reviewed Sep 18, 2019
View reviewed changes
@adelowo adelowo force-pushed the delete_releases_attachments_if_release_is_deleted branch from b21a621 to 9355bbc Compare September 18, 2019 12:19
@adelowo
Copy link
Member Author

adelowo commented Sep 18, 2019

TestToUTF8DropErrors is failing. Unrelated to this PR

@lunny Please take another look

@guillep2k
Copy link
Member

TestToUTF8DropErrors is failing. Unrelated to this PR

@lunny Please take another look

Based on the failure in the test I made #8192. It needs one more aproval. Anyway, I think that restarting this build should be enough (the tests only fail from time to time).

lunny
lunny requested changes Sep 19, 2019
View reviewed changes
lunny
lunny reviewed Sep 20, 2019
View reviewed changes
lunny
lunny requested changes Sep 20, 2019
View reviewed changes
@lafriks lafriks merged commit 63ff616 into go-gitea:master Sep 22, 2019
@guillep2k guillep2k mentioned this pull request Oct 9, 2019
Closed
@jolheiser jolheiser mentioned this pull request Feb 5, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Release attachments remain on disk after deleting the release