feat: support pid file.

[appleboy]

We can restart the app automatically by the following command.

kill -USR2 $(cat custom/run/app.pid)

[lunny]

Why we need a pid file?

[appleboy]

You can also use that information (just do a cat filename.pid) to kill the process yourself, using echo filename.pid | xargs kill. For develop purpose, you just build the binary and execute kill -USR2 $(cat custom/run/app.pid) command to restart app.

[tboerger]

I never needed that before but LGTM

[thibaultmeyer]

What happening if PID file already exist (ie: the app crash) ? app can be restarted without manually delete PID file ?

To avoid any issue or conflict with System D, supervisor, or other kind of tools. I think PID file could be created only if -p flag or explicit configuration on app.ini are specified

[appleboy]

@0xBAADF00D You don't worry about the PID file exists or not. App can be restarted successfully if you remove the pid file. Just try the following command.

gitea web
rm -rf custom/run/app.pid
kill -USR2 gitea_pid
cat custom/run/app.pid

[Bwko]

@appleboy What happens when a startup script also sets a PID?

[appleboy]

@Bwko What kind of start script do you use?

[ekozan]

what about windows ? it's work ?

[appleboy]

@ekozan Yes. Also working on Windows platform.

[appleboy]

@Bwko

Also working on start-stop-daemon command

[metalmatze]

Please check the error returned by os.MkdirAll().

[appleboy]

@metalmatze Done! Please review again.

[Bwko]

@appleboy Thanks 👍 When you add metalmatze suggestions I'll LGT-M 😄

[appleboy]

@Bwko Done!

[Bwko]

Quoting bkcsoft on this one:

Overall, change the format to this instead whenever possible. Keeps errors(variables) bound to their context(block).

if err := os.Create(...); err != nil { [...] }

[appleboy]

@Bwko We need file variable.

[Bwko]

Sorry my bad 😅

[Bwko]

Some nitpicking: missing a t here

[Bwko]

LGTM

[lunny]

need @metalmatze approve

[appleboy]

@lunny @Bwko @metalmatze Thanks