Fix install.tmpl input default value#611
Merged
Merged
Conversation
Contributor
vcaesar
commented
Jan 8, 2017
vcaesar
commented
- Fix install.tmpl input default value(index.js 212-215)
Bwko
reviewed
Jan 8, 2017
| } | ||
|
|
||
| $('#db_host').val("127.0.0.1:3306"); | ||
| $('#db_user').val("root"); |
Member
There was a problem hiding this comment.
Maybe gitea as default user is a better choice
Contributor
Author
There was a problem hiding this comment.
Because of the default user for the database is root,I think root is a better choice.
Member
There was a problem hiding this comment.
That's only true for MySQL/MariaDB not for PostgreSQL & MSSQL. Besides that I don't think that we should encourage users to use a root account "just because it's there".
Contributor
Author
There was a problem hiding this comment.
I see,"just because it's there" is not good and PostgreSQL & MSSQL is other,I updated.
Member
|
I think there was already a pr that resolves that |
tboerger
added
the
lgtm/need 2
Contributor
Author
|
@tboerger Because of format index.js,I resubmit. |
Member
|
LGTM |
tboerger
added
lgtm/need 1
Member
|
Default value has been added via #455 |
Contributor
Author
|
@lunny This is not the same problem. |
Member
|
LGTM |
tboerger
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.