Minor CSS cleanup for the navbar#6553
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6553 +/- ##
==========================================
- Coverage 40.37% 40.36% -0.02%
==========================================
Files 405 405
Lines 54260 54260
==========================================
- Hits 21907 21901 -6
- Misses 29337 29344 +7
+ Partials 3016 3015 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Apr 9, 2019
GiteaBot
added
lgtm/need 1
Member
Author
|
Small fix pushed to navbar height. Now the min-height is set on the navbar itself rather than the logo which should allow users to use logos less than 30px high. |
zeripath
approved these changes
Apr 10, 2019
GiteaBot
added
lgtm/done
Member
|
@silverwind any screenshot? |
Member
Author
|
Not much to show, but here you go: remove extra padding on the right side of the navbar:before
after
make navbar fixed height when logo is absent/not loaded yet:before
after
|
sapk
approved these changes
Apr 11, 2019
7 tasks
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 27, 2019
* Minor CSS cleanup for the navbar * move height fix to navbar Fixes: go-gitea#6776
techknowlogick
pushed a commit
that referenced
this pull request
Apr 29, 2019
techknowlogick
added
backport/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few minor tweaks related to the navbar:
!importantto navbar wrapper'smarginto eliminate a small gap visible in the navbar border on top-right caused by semantic-ui margins.min-heightto the logo to prevent navbar changing height while the image is still loading.