Skip to content

Fix org visibility bug when git cloning (#6743)#6762

Merged
lafriks merged 1 commit into
go-gitea:release/v1.8from
lunny:lunny/fix_perm2
Apr 26, 2019
Merged

Fix org visibility bug when git cloning (#6743)#6762
lafriks merged 1 commit into
go-gitea:release/v1.8from
lunny:lunny/fix_perm2

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Apr 26, 2019

  • fix org visibility bug

  • fix permission check

  • add integration tests

  • fix tests

  • change test user name for easier maintainance and fix test

  • fix test git repo name

Please check the following:

  1. Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
  2. Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
  3. Describe what your pull request does and which issue you're targeting (if any)

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

* fix org visibility bug

* fix permission check

* add integration tests

* fix tests

* change test user name for easier maintainance and fix test

* fix test git repo name
@lunny lunny added the type/bug label Apr 26, 2019
@lunny lunny added this to the 1.8.1 milestone Apr 26, 2019
@lunny
Copy link
Copy Markdown
Member Author

lunny commented Apr 26, 2019

back port from #6743 and will fix #6491

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2019
@lafriks lafriks merged commit 81adf6a into go-gitea:release/v1.8 Apr 26, 2019
@lunny lunny deleted the lunny/fix_perm2 branch April 26, 2019 13:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants