Skip to content

UI: Detect and restore encoding and BOM in content (#6727) #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zeripath
Copy link
Contributor

Detect and remove a decoded BOM when showing content.
Restore the previous encoding and BOM when updating content.
On error keep as UTF-8 encoding with no BOM.

Signed-off-by: Andrew Thornton [email protected]

Detect and remove a decoded BOM when showing content.
Restore the previous encoding and BOM when updating content.
On error keep as UTF-8 encoding.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Apr 26, 2019
@zeripath zeripath added this to the 1.8.1 milestone Apr 26, 2019
@zeripath zeripath changed the title Detect encoding and BOM in content (#6727) UI: Detect and restore encoding and BOM in content (#6727) Apr 26, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2019
@techknowlogick techknowlogick modified the milestones: 1.8.1, 1.9.0 Apr 27, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.8.1 Apr 27, 2019
@techknowlogick
Copy link
Member

make LG-TM work

@techknowlogick techknowlogick merged commit 21fb791 into go-gitea:release/v1.8 Apr 27, 2019
@zeripath zeripath deleted the fix-#6716-backport-v1.8 branch May 2, 2019 18:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants