Skip to content

Set user search base field optional in LDAP (simple auth) edit page#6779

Merged
techknowlogick merged 2 commits into
go-gitea:masterfrom
ngourdon:fix-6548
Apr 28, 2019
Merged

Set user search base field optional in LDAP (simple auth) edit page#6779
techknowlogick merged 2 commits into
go-gitea:masterfrom
ngourdon:fix-6548

Conversation

@ngourdon
Copy link
Copy Markdown
Contributor

@ngourdon ngourdon commented Apr 27, 2019

fix #6548

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 27, 2019

Codecov Report

Merging #6779 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6779      +/-   ##
=========================================
+ Coverage   40.99%     41%   +<.01%     
=========================================
  Files         421     421              
  Lines       58054   58054              
=========================================
+ Hits        23802   23803       +1     
+ Misses      31086   31085       -1     
  Partials     3166    3166
Impacted Files Coverage Δ
modules/log/router.go 90% <0%> (-2.5%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
models/unit.go 48.64% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81059a2...1df04e5. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 27, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2019
@techknowlogick
Copy link
Copy Markdown
Member

techknowlogick commented Apr 28, 2019

Make LG-TM work

@techknowlogick techknowlogick merged commit d29d97d into go-gitea:master Apr 28, 2019
@techknowlogick
Copy link
Copy Markdown
Member

techknowlogick commented Apr 28, 2019

Thanks for PR :) could you backport this to release/v1.8 branch?

ngourdon added a commit to ngourdon/gitea that referenced this pull request Apr 28, 2019
@ngourdon
Set user search base field optional in DLDAP edit page (go-gitea#6779)
5dc3667
@ngourdon ngourdon mentioned this pull request Apr 28, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 28, 2019
techknowlogick pushed a commit that referenced this pull request Apr 28, 2019
@ngourdon @techknowlogick
Set user search base field optional in DLDAP edit page (#6779) (#6789)
ed96b84
@ngourdon ngourdon deleted the fix-6548 branch June 2, 2019 13:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Can not update LDAP with simple auth after creation

6 participants

@ngourdon @codecov-io @techknowlogick @lunny @lafriks @GiteaBot