Skip to content

[WIP] Fix 6778#6794

Closed
sapk wants to merge 6 commits into
go-gitea:masterfrom
sapk-fork:fix-6778
Closed

[WIP] Fix 6778#6794
sapk wants to merge 6 commits into
go-gitea:masterfrom
sapk-fork:fix-6778

Conversation

@sapk
Copy link
Copy Markdown
Member

@sapk sapk commented Apr 29, 2019 •
edited
Loading

@lafriks lafriks added this to the 1.9.0 milestone Apr 29, 2019
@sapk
Copy link
Copy Markdown
Member Author

sapk commented Apr 29, 2019

The lib we use shouldn't return revoked ident but in this case it does.
For details, the relative test in the lib : https://github.com/keybase/go-crypto/blob/master/openpgp/keys_test.go#L519

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2019
@sapk sapk mentioned this pull request May 5, 2019
Closed
7 tasks
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 25, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Aug 24, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Aug 24, 2019
@stale stale Bot removed the issue/stale label Aug 24, 2019
@lunny lunny modified the milestones: 1.10.0, 1.11.0 Sep 15, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Nov 14, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Nov 14, 2019
@stale stale Bot removed the issue/stale label Dec 9, 2019
@techknowlogick techknowlogick modified the milestones: 1.11.0, 1.x.x Dec 12, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Feb 10, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Feb 10, 2020
@sapk sapk added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 10, 2020
@stale stale Bot removed the issue/stale label Feb 10, 2020
@sapk sapk added issue/stale and removed issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Feb 10, 2020
@stale stale Bot removed the issue/stale label Feb 10, 2020
@sapk
Copy link
Copy Markdown
Member Author

sapk commented Feb 12, 2020

@6543 the test is in the unit tests. And it is the one that failed.
This test should be ported to the source library to fix it there.

I haven't time to do so and only just quickly look at the code failing. but from time to time I update the lib to find if it fixed it 🤞 😄 .

@sapk
Copy link
Copy Markdown
Member Author

sapk commented Feb 12, 2020

Also we should maybe create a new key without user information. (I think it is order dependant)

@stale
Copy link
Copy Markdown

stale Bot commented Apr 12, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Apr 12, 2020
@6543
Copy link
Copy Markdown
Member

6543 commented Apr 12, 2020

@sapk can you update :)

@stale stale Bot removed the issue/stale label Apr 12, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Jun 13, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Jun 13, 2020
@6543
Copy link
Copy Markdown
Member

6543 commented Jun 13, 2020

is it fixed upstream?

@stale stale Bot removed the issue/stale label Jun 13, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Aug 13, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Aug 13, 2020
@6543
Copy link
Copy Markdown
Member

6543 commented Aug 13, 2020

we should update after #12481 got merged

@stale stale Bot removed the issue/stale label Aug 13, 2020
@6543
Copy link
Copy Markdown
Member

6543 commented Aug 13, 2020

ok @sapk can you update to test?

@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Aug 13, 2020

Are we sure it's still needed?

@6543
Copy link
Copy Markdown
Member

6543 commented Aug 13, 2020

#6778 is still open so I guess

@stale
Copy link
Copy Markdown

stale Bot commented Oct 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Oct 21, 2020
@6543
Copy link
Copy Markdown
Member

6543 commented Oct 21, 2020

update?

@stale stale Bot removed the issue/stale label Oct 21, 2020
@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Oct 21, 2020

#6778 was fixed by #12486 - I think we can close this

@zeripath zeripath closed this Oct 21, 2020
@lunny lunny removed this from the 1.x.x milestone Nov 19, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@sapk sapk deleted the fix-6778 branch November 29, 2020 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GPG not using correct UID

7 participants

@sapk @6543 @zeripath @lunny @techknowlogick @lafriks @GiteaBot