Fix 404 when send pull request some situation #6871
Merged
Merged
Conversation
zeripath
reviewed
May 7, 2019
GiteaBot
added
the
lgtm/need 2
Co-Authored-By: lunny <xiaolunwen@gmail.com>
zeripath
reviewed
May 7, 2019
zeripath
reviewed
May 7, 2019
zeripath
reviewed
May 7, 2019
Co-Authored-By: lunny <xiaolunwen@gmail.com>
Co-Authored-By: lunny <xiaolunwen@gmail.com>
Co-Authored-By: lunny <xiaolunwen@gmail.com>
Contributor
|
@lunny, would it be possible to write a document somewhere explaining what the permissions should be doing things? (This isn't the PR for that I know but I think it's a good example of one where we're not very clear about what permissions things should have.) |
zeripath
approved these changes
May 7, 2019
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #6871 +/- ##
=========================================
Coverage ? 41.33%
=========================================
Files ? 432
Lines ? 59532
Branches ? 0
=========================================
Hits ? 24607
Misses ? 31689
Partials ? 3236
Continue to review full report at Codecov.
|
lafriks
approved these changes
May 7, 2019
GiteaBot
added
lgtm/done
Contributor
|
@lunny are you able to backport? |
Member
Author
|
@zeripath I think that's a good idea. I will do that. |
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
May 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With integration tests and should fix #6302