Fixes #6881 - API users search fix#6882
Merged
Merged
Conversation
techknowlogick
approved these changes
May 8, 2019
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
May 8, 2019
GiteaBot
added
lgtm/done
Member
|
Great, thanks for adding tests! 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #6882 +/- ##
==========================================
+ Coverage 41.33% 41.41% +0.08%
==========================================
Files 432 432
Lines 59552 59552
==========================================
+ Hits 24613 24666 +53
+ Misses 31701 31646 -55
- Partials 3238 3240 +2
Continue to review full report at Codecov.
|
Member
|
Please send backport |
richmahn
added a commit
to richmahn/gitea
that referenced
this pull request
May 9, 2019
techknowlogick
added
the
backport/done
lunny
pushed a commit
that referenced
this pull request
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6881
Fixes the user search if not using auth. No login/user should be needed for user search. Adds integration tests to make sure logged in, logged in as admin, and not logged in all work, where the former shows emails unless queried user has made their email private, the 2nd shows all emails, latter shows no emails.
Also set in admin API.
Test using the swagger page.