Add FHS-compliant-script #6923
Merged
Add FHS-compliant-script #6923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #6923 +/- ##
==========================================
- Coverage 41.45% 41.44% -0.01%
==========================================
Files 442 442
Lines 59610 59610
==========================================
- Hits 24711 24708 -3
- Misses 31669 31672 +3
Partials 3230 3230
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
mrsdizzie
reviewed
May 14, 2019
mrsdizzie
reviewed
May 14, 2019
| APP_INI="/etc/gitea/app.ini" | ||
|
|
||
| APP_INI_SET="" | ||
| for i in "$@"; do |
There was a problem hiding this comment.
Just realised I should put $CONF_ARG bit first just in case we have commands with arguments later.
mrsdizzie
approved these changes
May 14, 2019
GiteaBot
added
lgtm/need 1
techknowlogick
added
the
topic/distribution
|
@mrsdizzie do you think we should be setting HOME too? |
|
I think it's probably ok not setting HOME actually - everything that defaults to using it can be set with app.ini. |
|
Agree, $HOME should just be whatever it is and we shouldn't mess with it |
techknowlogick
approved these changes
May 26, 2019
GiteaBot
added
lgtm/done
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a contrib script that recommends shadowing the gitea binary on debian systems and sets environment variable defaults for these systems.
This should probably be considered a WIP or suggestion unless people think it's exactly right.