Fix LFS Locks over SSH#6999
Merged
Merged
Conversation
Member
|
It seems there is an issue reported that. |
Contributor
Author
|
@lunny do you know which issue it is because I can't seem to easily find it. |
Member
|
Maybe it is #5478 |
Contributor
Author
lafriks
approved these changes
May 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #6999 +/- ##
=========================================
Coverage ? 41.43%
=========================================
Files ? 442
Lines ? 59693
Branches ? 0
=========================================
Hits ? 24731
Misses ? 31725
Partials ? 3237
Continue to review full report at Codecov.
|
sapk
suggested changes
May 21, 2019
sapk
reviewed
May 22, 2019
Contributor
Author
|
@sapk have you been able to test this yet? git_test.go does test the locking now btw. |
lunny
requested changes
May 26, 2019
Member
|
@zeripath not much time to do so lately. So if someone other validate it should be good as my requested changes are done. |
lunny
approved these changes
May 28, 2019
Member
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jun 16, 2019
* Fix LFS Locks over SSH * Mark test as skipped
zeripath
added a commit
that referenced
this pull request
Jun 17, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Fix LFS Locks over SSH * Mark test as skipped
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst looking at adding more tests for #6993 I've noticed that LFS locking was not-preauthenticating correctly over SSH.
This PR fixes this.
Fixes #3084