Fix default for allowing new organization creation for new users

[jpicht]

When creating users DefaultAllowCreateOrganization was ignored.

This is simple two-line fix for issue #6542.

[zeripath]

~~Looking at the code I think these two settings need to be coalesced. It doesn't appear that DEFAULT_ALLOW_CREATE_ORGANIZATION is wired into anything at all. ~~

[zeripath]

We should probably just kill DEFAULT_ALLOW_CREATE_ORGANIZATION let's just rewire it back in and fix the test

[jpicht]

I can certainly do that as well. Should there be a warning if somebody has it set in the config file? Is there a place to add a message to, so it will end up in the release notes?

[zeripath]

Hmm... let's just fix the test. I think that's the correct thing to do.

Make line 263:

gitea/models/user_test.go

Lines 262 to 264 in 6eb53ac

	}
	for _, v := range tt {

setting.Service.DefaultAllowCreateOrganization = true

[jpicht]

I ran the drone test locally before creating this pull request. It seems the test did not fail for me. What did I do wrong? The output can be found here: https://gist.github.com/jpicht/6337485ab466776fded3ee22089d45dc

[zeripath]

You didn't run the unit tests - that is make test - your logs indicate you only ran the integration tests

[codecov-io]

Codecov Report

Merging #7017 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7017      +/-   ##
==========================================
- Coverage    41.5%   41.48%   -0.02%     
==========================================
  Files         440      440              
  Lines       59453    59452       -1     
==========================================
- Hits        24675    24663      -12     
- Misses      31558    31570      +12     
+ Partials     3220     3219       -1

Impacted Files	Coverage Δ
models/user.go	50.88% <100%> (-0.05%)	⬇️
models/unit.go	62.16% <0%> (-5.41%)	⬇️
modules/log/event.go	64.46% <0%> (-1.53%)	⬇️
models/repo_list.go	72.08% <0%> (-1.02%)	⬇️
routers/repo/view.go	42.02% <0%> (-1.02%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb53ac...7301c69. Read the comment docs.

[jpicht]

You didn't run the unit tests - that is make test - your logs indicate you only ran the integration tests

Thanks! That step should probably be added to the contributors guide.

[lafriks]

Make lgtm work

[lafriks]

Please send backport to release/v1.8 branch