Skip to content

fix: delete attachment after remove comment. #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2017
Merged

fix: delete attachment after remove comment. #704

merged 1 commit into from
Jan 25, 2017

Conversation

appleboy
Copy link
Member

We need to merge XORM bugs first go-xorm/xorm#525 and also update vendor files.

ref: #677 (comment)

@lunny lunny added this to the 1.1.0 milestone Jan 20, 2017
@lunny lunny added the type/bug label Jan 20, 2017
@lunny
Copy link
Member

lunny commented Jan 25, 2017

@appleboy go-xorm/xorm#525 merged.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2017
@appleboy appleboy changed the title [WIP] fix: delete attachment after remove comment. fix: delete attachment after remove comment. Jan 25, 2017
@appleboy
Copy link
Member Author

@lunny update go-xorm package and rebased.

@appleboy appleboy mentioned this pull request Jan 25, 2017
Closed
4 tasks
@lunny
Copy link
Member

lunny commented Jan 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jan 25, 2017

LGTM

@bkcsoft
Copy link
Member

bkcsoft commented Jan 25, 2017

Make LGTM WORK!

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2017
@bkcsoft bkcsoft merged commit 691fbdf into go-gitea:master Jan 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@appleboy @lunny @bkcsoft @tboerger