Skip to content

Add ETag header to avatars #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lunny merged 1 commit into from
Jan 25, 2017
Merged

Add ETag header to avatars #721

lunny merged 1 commit into from
Jan 25, 2017

Conversation

@Bwko
Copy link
Member

@Bwko Bwko commented Jan 22, 2017

Fixes #165

@lunny lunny added this to the 1.1.0 milestone Jan 22, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 22, 2017
@lunny
Copy link
Member

lunny commented Jan 22, 2017

Why add etag?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2017
@Bwko
Copy link
Member Author

Bwko commented Jan 22, 2017

To fix #165, changing cache headers won't give the desired result.

@lunny
Copy link
Member

lunny commented Jan 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2017
@appleboy
Copy link
Member

appleboy commented Jan 25, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2017
@lunny lunny merged commit 8555e88 into go-gitea:master Jan 25, 2017
@Bwko Bwko deleted the etag branch January 25, 2017 11:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

Organization custom avatar only gets updated on browser cache reset

4 participants

@Bwko @lunny @appleboy @tboerger