Always set userID on LFS authentication#7224
Merged
Merged
Conversation
Contributor
Author
|
OK, the first commit could still lead to problems with getting LFS files from public repos using deploy keys that are not associated with this deploy key. I think deploy keys should only be used to read repositories that they are associated with, not just any repository - and in fact #6993 did this. The second commit in this PR replicates this change of semantics. |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jun 17, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jun 17, 2019
GiteaBot
added
lgtm/done
7 tasks
7 tasks
|
It would be nice if, any reviewer who reviewed this ticket, could draw the attention to #8273. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5478 on 1.8
Fix #7219 on 1.8
These issues are fixed on 1.9 through #6993 which is too major a change to backport to 1.8.