[Branch View] code format#7603
Closed
6543 wants to merge 2 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7603 +/- ##
==========================================
- Coverage 41.24% 41.24% -0.01%
==========================================
Files 469 469
Lines 63608 63608
==========================================
- Hits 26236 26232 -4
- Misses 33952 33957 +5
+ Partials 3420 3419 -1
Continue to review full report at Codecov.
|
silverwind
approved these changes
Jul 25, 2019
Contributor
|
This change does not really warrant classing as a PR. Surely this could be folded into a different PR? |
Member
Author
Contributor
|
Oh I agree about having good code formatting but I think you're changing all the lines nearby this in another pr - so just put it there. Small formatting PRs are just noise. |
Member
Author
|
-> #7622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of PR #7520
and issue #7454