Add ENABLE_PPROF to app.ini and start pprof if true on localhost:6060#801
Merged
Conversation
Member
|
why not put it on the admin panel |
Contributor
Author
|
If one enables pprof in the admin panel, would they just set this variable that I used to |
Member
|
Should there be a PPROF_LISTEN_PORT too ?
|
Contributor
Author
|
I don't think so. Port |
Member
|
LGTM |
appleboy
approved these changes
Feb 5, 2017
Member
|
LGTM |
Member
|
let L-G-T-M work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #753 I want a simple way for people to enable pprof so they can debug with our help, or on their own, growing memory consumption or CPU usage.
For that I added
ENABLE_PPROFto theapp.ini.If set to true gitea will start pprof on localhost:6060 with the
gitea webcommand.https://blog.golang.org/profiling-go-programs
https://golang.org/pkg/net/http/pprof/