Skip to content

Add more databases support on unit tests #8349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 2, 2019

fix #8348

@lunny lunny added pr/wip This PR is not ready for review type/testing labels Oct 2, 2019
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #8349 into master will decrease coverage by 0.04%.
The diff coverage is 15.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8349      +/-   ##
==========================================
- Coverage    41.8%   41.75%   -0.05%     
==========================================
  Files         497      497              
  Lines       65603    65671      +68     
==========================================
  Hits        27424    27424              
- Misses      34662    34725      +63     
- Partials     3517     3522       +5
Impacted Files Coverage Δ
models/unit_tests.go 49.73% <15.94%> (-19.69%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 42.53% <0%> (-1.02%) ⬇️
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e2ce6...26c29c4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 2, 2019
@lunny lunny force-pushed the lunny/unit_tests_support_more_dbs branch from 3f1fd36 to 26c29c4 Compare October 6, 2019 08:21
@guillep2k
Copy link
Member

@lunny, I'd recommend to simplify the charset package test or even remove it. It's still failing randomly, presumably because of different settings on each server. After all this time I guess they make not much sense, as the "golang.org/x/net/html/charset" functions seem to fail only when memory is very short. Comparing conversions between invalid strings was a bad idea from my part. 😳

What do you think?

image

@stale
Copy link

stale bot commented Dec 5, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 5, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 5, 2019
@stale stale bot removed the issue/stale label Dec 5, 2019
@lunny
Copy link
Member Author

lunny commented Dec 22, 2020

It seems this is unnecessary. Just close this.

@lunny lunny closed this Dec 22, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
@lunny lunny deleted the lunny/unit_tests_support_more_dbs branch November 4, 2021 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests with mysql/postgres/mssql
4 participants