-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add more databases support on unit tests #8349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8349 +/- ##
==========================================
- Coverage 41.8% 41.75% -0.05%
==========================================
Files 497 497
Lines 65603 65671 +68
==========================================
Hits 27424 27424
- Misses 34662 34725 +63
- Partials 3517 3522 +5
Continue to review full report at Codecov.
|
3f1fd36
to
26c29c4
Compare
@lunny, I'd recommend to simplify the charset package test or even remove it. It's still failing randomly, presumably because of different settings on each server. After all this time I guess they make not much sense, as the What do you think? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
It seems this is unnecessary. Just close this. |
fix #8348