Skip to content

Doc config file should not be readable by others #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Doc config file should not be readable by others #8385

merged 1 commit into from
Oct 5, 2019

Conversation

8ctopus
Copy link
Contributor

@8ctopus 8ctopus commented Oct 5, 2019

app.ini should not have 644 permissions but 640.

@codecov-io
Copy link

Codecov Report

Merging #8385 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8385      +/-   ##
==========================================
- Coverage   41.79%   41.78%   -0.01%     
==========================================
  Files         497      497              
  Lines       65603    65603              
==========================================
- Hits        27418    27414       -4     
- Misses      34669    34674       +5     
+ Partials     3516     3515       -1
Impacted Files Coverage Δ
models/repo_indexer.go 66.27% <0%> (-1.94%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd41a04...33439ba. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2019
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Oct 5, 2019
@lafriks lafriks merged commit 8a82850 into go-gitea:master Oct 5, 2019
@8ctopus 8ctopus deleted the config-permissions branch October 6, 2019 02:40
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants