Implement archive cleanup#885
Merged
Merged
Conversation
Fixes go-gitea#769 Signed-off-by: Andrew <write@imaginarycode.com>
lunny
reviewed
Feb 10, 2017
|
|
||
| for _, ty := range []string{"zip", "targz"} { | ||
| path := filepath.Join(basePath, ty) | ||
| file, err := os.Open(path) |
lunny
added
the
type/feature
Member
|
LGTM |
tboerger
added
the
lgtm/need 1
strk
approved these changes
Feb 10, 2017
Member
strk
left a comment
strk
left a comment
There was a problem hiding this comment.
LGTM - please also update documentation (ini cheatsheet)
| for _, info := range files { | ||
| if info.ModTime().Before(minimumOldestTime) && !info.IsDir() { | ||
| toDelete := filepath.Join(path, info.Name()) | ||
| // This is a best-effort purge, so we do not check error codes to confirm removal. |
Member
There was a problem hiding this comment.
I'd still trace-print any error (could be something a sysadmin could fix...)
| if err := x. | ||
| Where("id > 0"). | ||
| Iterate(new(Repository), | ||
| func(idx int, bean interface{}) error { |
Member
There was a problem hiding this comment.
Could this be defined as a standalone function, for better readability ?
Member
|
As my review wasn't immediately recognized by the bot, I'll take the chance to ask you to deal with the two comments I've added before convincing the bot :) |
Member
|
LGTM now - although I don't know how cheatsheet is generated |
tboerger
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #769.
This allows Gitea to automatically purge created archives in order to better control disk space usage. Currently, archives older than 24 hours will be purged every 24 hours.