eliminate horizontal scroll caused by footer

[silverwind]

fixes an issue with horizontal scroll on all pages on mobile, caused by the page footer being too wide for some reason.

Before (notice horizontal scrollbar)

After (no more horizontal scrollbar)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@a311ace). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9669   +/-   ##
=========================================
  Coverage          ?   42.25%           
=========================================
  Files             ?      587           
  Lines             ?    77987           
  Branches          ?        0           
=========================================
  Hits              ?    32956           
  Misses            ?    40991           
  Partials          ?     4040

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a311ace...e3b96ea. Read the comment docs.

[guillep2k]

Back to !important are we, isn't it? 🤣

[silverwind]

Yeah, it's needed because it is overriding this style from fomantic:

.ui.container {
    max-width: 100%;
}

[zeripath]

We really do need to move to less completely...

[zeripath]

Please send backport to v1.11

[silverwind]

We really do need to move to less completely...

Not sure I follow. Personally, I'd rather move to Sass 😉

[zeripath]

I meant build our CSS directly from fomantic less by integrating with its theming system etc. so we can drop those !important

[silverwind]

Ah, yes. I don't think we actually need to integrate that tightly. Theoretically it's enough if our styles are loaded after the fomantic styles for them to win. Still, I prefer to "reinforce" statements via !important just to make sure they stick. I see !important as more maintainable than trying to keep up with changes on fomantic's side and there will always be a certain amount of styles that will need to be overwritten because fomantic is very opinionated.