Skip to content

Load milestone in API PR list #9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techknowlogick merged 6 commits into from
Jan 10, 2020
Merged

Load milestone in API PR list #9671

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6d3fd98
Load milestone for Issue API format
jolheiser Jan 9, 2020
1ed18f8
Move further down
jolheiser Jan 9, 2020
1ca941a
Merge branch 'master' into load_milestone
lafriks Jan 9, 2020
1000748
Merge branch 'master' into load_milestone
lunny Jan 10, 2020
5de6e42
Merge branch 'master' into load_milestone
jolheiser Jan 10, 2020
c2c1c0c
Merge branch 'master' into load_milestone
techknowlogick Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,12 @@ func (issue *Issue) apiFormat(e Engine) *api.Issue {
apiIssue.Closed = issue.ClosedUnix.AsTimePtr()
}

issue.loadMilestone(e)
if issue.Milestone != nil {
apiIssue.Milestone = issue.Milestone.APIFormat()
}
issue.loadAssignees(e)

issue.loadAssignees(e)
if len(issue.Assignees) > 0 {
for _, assignee := range issue.Assignees {
apiIssue.Assignees = append(apiIssue.Assignees, assignee.APIFormat())
Expand Down