Move Errored PRs out of StatusChecking#9675
Merged
Merged
Conversation
lafriks
approved these changes
Jan 9, 2020
GiteaBot
added
the
lgtm/need 1
jolheiser
suggested changes
Jan 9, 2020
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com>
jolheiser
approved these changes
Jan 9, 2020
GiteaBot
added
lgtm/done
zeripath
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9675 +/- ##
==========================================
- Coverage 42.25% 42.25% -0.01%
==========================================
Files 587 587
Lines 77991 77991
==========================================
- Hits 32954 32952 -2
- Misses 40995 40997 +2
Partials 4042 4042
Continue to review full report at Codecov.
|
Member
|
Please send back port. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 12, 2020
* Set Errored PRs out of StatusChecking * Ensure that api status is correctly set too * Update models/pull.go Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com> Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com>
sapk
pushed a commit
that referenced
this pull request
Jan 12, 2020
* Move Errored PRs out of StatusChecking (#9675) * Set Errored PRs out of StatusChecking * Ensure that api status is correctly set too * Update models/pull.go Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com> Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com> * Update services/pull/check.go Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the consequences of the fix in #9282 to ensure that PRs are rechecked is that an PR which errors in TestPatch will remain in StatusChecking. This previously didn't matter as PRs would never get rechecked whilst Gitea was running however now this means that these broken PRs will get repeatedly tested.
This PR moves these PRs to StatusError.