Never allow an empty password to validate

[zeripath]

#6023 caused a regression.

[silverwind]

Maybe add a test?

[lafriks]

Does not seem to work, all tests fail

[zeripath]

Yeah, so the reason tests failed is because I wrote:

// IsPasswordSet checks if the password is set or left empty
func (u *User) IsPasswordSet() bool {
       return u.ValidatePassword("")
}

instead of:

// IsPasswordSet checks if the password is set or left empty
func (u *User) IsPasswordSet() bool {
       return !u.ValidatePassword("")
}

yes, I'm an eejit.

[codecov-io]

Codecov Report

Merging #9682 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #9682      +/-   ##
=========================================
- Coverage    42.2%   42.2%   -0.01%     
=========================================
  Files         591     591              
  Lines       78085   78085              
=========================================
- Hits        32959   32953       -6     
- Misses      41080   41085       +5     
- Partials     4046    4047       +1

Impacted Files	Coverage Δ
models/user.go	50.77% <100%> (ø)	⬆️
models/unit.go	62.16% <0%> (-5.41%)	⬇️
modules/process/manager.go	74.69% <0%> (-3.62%)	⬇️
services/pull/temp_repo.go	31.62% <0%> (-2.57%)	⬇️
modules/queue/workerpool.go	39.91% <0%> (-1.29%)	⬇️
modules/log/event.go	64.61% <0%> (-1.03%)	⬇️
services/pull/check.go	53.37% <0%> (+4.72%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fb813...465caef. Read the comment docs.