Don't attempt to close issue if already closed

[guillep2k]

Fixes #9695

Couldn't reproduce, however, neither with a commit message or a text reference. Tested with master (0c0ebe49ea4fd0d3ecc2aac9dfe2d7ce64381145) and v1.11.0-rc1.

Update

I can reproduce if the issue is closed from both the commit message and a text reference. This PR fixes that.

[codecov-io]

Codecov Report

Merging #9696 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9696      +/-   ##
==========================================
- Coverage   42.25%   42.24%   -0.02%     
==========================================
  Files         590      590              
  Lines       78005    78004       -1     
==========================================
- Hits        32961    32952       -9     
- Misses      41001    41012      +11     
+ Partials     4043     4040       -3

Impacted Files	Coverage Δ
routers/api/v1/repo/repo.go	69.55% <ø> (-0.04%)	⬇️
models/issue.go	55.02% <100%> (ø)	⬆️
services/pull/check.go	50.67% <0%> (-2.71%)	⬇️
models/webhook.go	69.39% <0%> (-1.07%)	⬇️
routers/repo/view.go	38.59% <0%> (-0.88%)	⬇️
models/error.go	31.6% <0%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4935b47...d0fb57c. Read the comment docs.

[6543]

I would say backport ;)

[guillep2k]

I would say backport ;)

I always wait for the approvals and merge before backporting. You never know... 😁

[6543]

sure :) I thought about the **lable** Am January 10, 2020 7:33:15 PM UTC schrieb guillep2k <notifications@github.com>:

…

> > > > > I would say backport ;)> > I always wait for the approvals and merge before backporting. You never know... 😁> > -- > You are receiving this because you commented.> Reply to this email directly or view it on GitHub:> #9696 (comment)

[lunny]

@guillep2k Please send back port to v1.11