silence fomantic error regarding tabs#9713
Merged
Merged
Conversation
Fomantic expects all tabs to have a target element with content as defined by the data-tab attribute. All our usage of the tab module seems to use <a> element tabs that link to new pages so these content elements are never present and fomantic complains about that in the console with an "Activated tab cannot be found" error. This silences that error.
zeripath
approved these changes
Jan 11, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
added
backport/v1.11
type/bug
topic/ui
6543
approved these changes
Jan 12, 2020
GiteaBot
added
lgtm/done
Member
|
@silverwind please send a backport to v1.11 if possible. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Jan 12, 2020
Fomantic expects all tabs to have a target element with content as defined by the data-tab attribute. All our usage of the tab module seems to use <a> element tabs that link to new pages so these content elements are never present and fomantic complains about that in the console with an "Activated tab cannot be found" error. This silences that error.
Member
Author
|
backport in #9718 |
techknowlogick
pushed a commit
that referenced
this pull request
Jan 12, 2020
Fomantic expects all tabs to have a target element with content as defined by the data-tab attribute. All our usage of the tab module seems to use <a> element tabs that link to new pages so these content elements are never present and fomantic complains about that in the console with an "Activated tab cannot be found" error. This silences that error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fomantic expects all tabs to have a target element with content as defined by the
data-tabattribute. All our usage of the tab module seems to use<a>element tabs that link to new pages so these content elements are never present and fomantic complains about that in the console withan "Activated tab cannot be found" error. This silences that error.
Ref: https://fomantic-ui.com/modules/tab.html
Errors can be seen in the browser console on every page containing those link-style tabs, for example https://try.gitea.io/silverwind/symlink-test.