Skip to content

Check user != nil before checking values#9881

Merged
techknowlogick merged 3 commits into
go-gitea:masterfrom
zeripath:fix-9809
Jan 19, 2020
Merged

Check user != nil before checking values#9881
techknowlogick merged 3 commits into
go-gitea:masterfrom
zeripath:fix-9809

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented Jan 19, 2020

Fix #9809

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 19, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2020
@zeripath
Copy link
Copy Markdown
Contributor Author

zeripath commented Jan 19, 2020 •
edited
Loading

This won't update the admin status though - so I think I need to do something a little cleverer... - DONE

@zeripath
Copy link
Copy Markdown
Contributor Author

zeripath commented Jan 19, 2020 •
edited
Loading

It's quite inefficient I think but I guess it'll do?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3d46b49). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9881   +/-   ##
=========================================
  Coverage          ?   42.27%           
=========================================
  Files             ?      605           
  Lines             ?    79248           
  Branches          ?        0           
=========================================
  Hits              ?    33500           
  Misses            ?    41616           
  Partials          ?     4132
Impacted Files Coverage Δ
models/migrations/migrations.go 1.3% <ø> (ø)
models/migrations/v124.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d46b49...deb17a2. Read the comment docs.

@techknowlogick techknowlogick merged commit dcf7e85 into go-gitea:master Jan 19, 2020
@6543
Copy link
Copy Markdown
Member

6543 commented Jan 19, 2020

need backport

6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jan 19, 2020
@zeripath @6543
Check user != nil before checking values (go-gitea#9881)
961dc60 
* Check user != nil before checking values

* Handle autoAdmin
@6543 6543 mentioned this pull request Jan 19, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 19, 2020
techknowlogick pushed a commit that referenced this pull request Jan 20, 2020
@6543 @zeripath @techknowlogick
Check user != nil before checking values (#9881) (#9883)
ce756ee 
* Check user != nil before checking values

* Handle autoAdmin

Co-authored-by: zeripath <art27@cantab.net>
@zeripath zeripath deleted the fix-9809 branch January 20, 2020 07:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@jolheiser jolheiser jolheiser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

LDAP BindDN Multiple Log In Options Results in 500

6 participants

@zeripath @codecov-io @6543 @techknowlogick @jolheiser @GiteaBot