Fix RocketChat Webhook (#9908) (#9921)#9925
Merged
lafriks merged 1 commit intoJan 22, 2020
Merged
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
commented
Jan 21, 2020
Comment on lines
389
to
-388
| text = fmt.Sprintf("[%s] Repository created by %s", p.Repository.FullName, senderLink) | ||
| title = p.Repository.HTMLURL |
Member
Author
There was a problem hiding this comment.
In 1.11+ the reason it made sense to remove the repo link from the title is because [%s] was turned into a repo link (with fullname for text).
If we still want to send a link to the repo in 1.10, this would require additional changes...
GiteaBot
added
the
lgtm/need 2
guillep2k
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to
release/v1.10This commit is not cherry-picked because the files moved between 1.10-1.11 but they are the same changes.