Check if diff actually contains sections when rendering#9926
Merged
Conversation
techknowlogick
approved these changes
Jan 21, 2020
Member
|
should this be backport to 1.11? |
Member
Author
|
yes, v1.11 also have this bug |
zeripath
approved these changes
Jan 21, 2020
Member
|
I think it was regressed in 149a9df which does not seem present on v1.10. |
Codecov Report
@@ Coverage Diff @@
## master #9926 +/- ##
==========================================
- Coverage 42.28% 42.27% -0.02%
==========================================
Files 608 608
Lines 79392 79392
==========================================
- Hits 33573 33562 -11
- Misses 41679 41688 +9
- Partials 4140 4142 +2
Continue to review full report at Codecov.
|
Member
|
@lafriks please rebase. |
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Jan 22, 2020
zeripath
pushed a commit
that referenced
this pull request
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9807