This repository was archived by the owner on Jun 8, 2019. It is now read-only.
Adjust keys API#121
Merged
Merged
Conversation
Signed-off-by: Andrew Thornton <art27@cantab.net>
This was referenced Sep 19, 2018
lafriks
approved these changes
Sep 20, 2018
Member
|
Blocked till 1.6.0 is released |
lunny
approved these changes
Oct 22, 2018
sapk
approved these changes
Oct 22, 2018
sapk
approved these changes
Oct 22, 2018
adelowo
approved these changes
Oct 22, 2018
adelowo
approved these changes
Oct 22, 2018
adelowo
approved these changes
Oct 22, 2018
lunny
approved these changes
Oct 22, 2018
Member
|
make lgtm work |
Member
|
make github work 😄 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The results of the API for both the repo ssh keys and the user ssh keys lacks several important features.
This pull request adjusts the API to allow reporting of the key id for the keys reported by
/repos/{owner}/{repo}/keysand the owner, keytype and read_only type for the keys reported by/user/keys.(Of note
/user/keysdoes not only just return user keys but also deploy keys.)