Skip to content

Conversation

@genofire
Copy link

This Library should not crash on rollback
(maybe define an extra Error would be an alternative)

This Library should not crash on rollback
(maybe define an extra Error would be an alternative)
@avakarev
Copy link
Contributor

avakarev commented Jun 7, 2023

Hi @genofire, thank you for contribution.
Can you please add steps to reproduce it? What does it mean "crash"? It would be nice to know the db driver too.
I have tested the use-case when Rollback is called before Migrate, so migrations database doesn't exist, and gomigrate propagate the errors properly.
Error message and type is different for different drivers though.

@genofire
Copy link
Author

it is 3 years ago ...


if you call rollback before any Migration happens, it will always crash (independent von db driver).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants