Merged
Conversation
Refactor DBUpdates to: - Use x/options.Map to extract the since parameter properly - Treat since as an opaque string value (not converting to int64) - Build WHERE clause conditionally based on whether since is provided - Support integer and string representations of sequence IDs Changes: - Add since parameter filtering to historical queries - Use options.Map.Get() for consistent option extraction - Remove manual type conversions and hardcoded defaults - Add test case verifying since parameter filters results correctly
Add validation of the feed parameter using x/options.Map.Feed() to ensure only supported feed types (normal, longpoll, continuous) are accepted. Invalid feed values return HTTP 400 with appropriate error message. This validates the feed parameter early in DBUpdates processing, rejecting invalid values before attempting to query the database.
Add "deleted" event logging to DestroyDB to track when databases are destroyed. Events are logged atomically within the same transaction as schema drops.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
+ Coverage 61.38% 61.39% +0.01%
==========================================
Files 293 293
Lines 19305 19305
==========================================
+ Hits 11851 11853 +2
+ Misses 6901 6900 -1
+ Partials 553 552 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.