Skip to content

Multiple test failures with Go 1.16 beta 1 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eclipseo opened this issue Jan 24, 2021 · 4 comments
Closed

Multiple test failures with Go 1.16 beta 1 #139

eclipseo opened this issue Jan 24, 2021 · 4 comments

Comments

@eclipseo
Copy link

On Fedora Rawhide with Go 1.16 beta 1, the following tests fails:

Testing    in: /builddir/build/BUILD/validate-0.20.0/_build/src
         PATH: /builddir/build/BUILD/validate-0.20.0/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/validate-0.20.0/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags " -X github.com/go-openapi/validate/version=0.20.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld  '"
      testing: github.com/go-openapi/validate
github.com/go-openapi/validate
--- FAIL: TestStringItemsValidation (0.00s)
    items_validator_test.go:180: 
        	Error Trace:	items_validator_test.go:180
        	Error:      	Error message not equal:
        	            	expected: "tags.1 in query must be of type string: \"null\""
        	            	actual  : "tags.1 in query should be at least 3 chars long"
        	Test:       	TestStringItemsValidation
--- FAIL: TestStringParameterValidation (0.00s)
    parameter_validator_test.go:152: 
        	Error Trace:	parameter_validator_test.go:152
        	Error:      	Error message not equal:
        	            	expected: "name in query must be of type string: \"null\""
        	            	actual  : "name in query is required"
        	Test:       	TestStringParameterValidation
--- FAIL: Test_Issue1621 (1.34s)
    messages_test.go:435: 
        	Error Trace:	messages_test.go:435
        	            				spec_test.go:660
        	Error:      	"[/v4/clusters/{cluster_id}/.examples.kubernetes_version in body must be of type string: "null"]" should have 0 item(s), but has 1
        	Test:       	Test_Issue1621
    messages_test.go:436: Returned warnings:
    messages_test.go:438: /v4/clusters/{cluster_id}/.examples.kubernetes_version in body must be of type string: "null"
FAIL
exit status 1
FAIL	github.com/go-openapi/validate	18.998s 
@eclipseo
Copy link
Author

It's because I use a newer github.com/go-openapi/errors
Closing.

@eclipseo
Copy link
Author

Actually I use the correct one, version 0.19.9

@eclipseo eclipseo reopened this Jan 24, 2021
@fredbi
Copy link
Member

fredbi commented Jan 24, 2021

@eclipseo a recent commit was supposed to address go1.16 specifics, in particular affecting the required check: #138

Can you reproduce your issue with v0.20.0? (just before that commit)

@eclipseo
Copy link
Author

I was using 0.20.0, it seems to be fixed with 0.20.1 indeed.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants