Skip to content

remove apparently useless condition check #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2021
Merged

remove apparently useless condition check #138

merged 1 commit into from
Jan 16, 2021

Conversation

casualjim
Copy link
Member

fixes #137

@fredbi
Copy link
Member

fredbi commented Jan 13, 2021

Looks like we have to disable some unwanted linters again (forbigo, thelper). Dunno why they keep stacking so many things by default...

@fredbi fredbi merged commit f04e0d7 into master Jan 16, 2021
anitgandhi added a commit to digitalocean/validate that referenced this pull request Feb 25, 2021
… v0.19.8

As reported in go-openapi#137, changes in Go 1.16's `reflect` package cause the type validator to fail now. Incorporate a fix from go-openapi#138 to fix that.

For the time being, for internal compatibility and transitive dependency issues, we need to stick with v0.19.8. But to unblock upgrading to Go 1.16.0, we need this hotfix.
diafour pushed a commit to flant/go-openapi-validate that referenced this pull request Oct 6, 2021
@fredbi fredbi deleted the go-116-prep branch February 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.16 will change behavior of what appears to be a buggy conditional
2 participants